waivers/+filtered API endpoint: handle scenarios (#431) #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FilteredWaiversResource method which backs this endpoint tries to find only 'current' waivers by grouping all waivers by subject_type, subject_identifier and testcase, then taking only the highest-numbered waiver from each group. This breaks if we have multiple waivers for the same subject and testcase but with different scenarios - the endpoint will only return one waiver, the one with the highest ID, and will not return the valid and current waivers for other scenarios as it should. Signed-off-by: Adam Williamson <awilliam@redhat.com>
|
I'm pretty sure it's safe to do this even for waivers with no scenario, as the scenario will just be considered to be |
|
Good catch. Thanks for the fix! I'll deploy the fix after testing this internally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FilteredWaiversResource method which backs this endpoint tries to find only 'current' waivers by grouping all waivers by subject_type, subject_identifier and testcase, then taking only the highest-numbered waiver from each group. This breaks if we have multiple waivers for the same subject and testcase but with different scenarios - the endpoint will only return one waiver, the one with the highest ID, and will not return the valid and current waivers for other scenarios as it should.