Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlight.js v9 EOL #147

Closed
elwayman02 opened this issue Oct 11, 2021 · 1 comment
Closed

highlight.js v9 EOL #147

elwayman02 opened this issue Oct 11, 2021 · 1 comment

Comments

@elwayman02
Copy link
Contributor

highlightjs/highlight.js#2877

This EOL warning comes up when generating changelogs with this package.

Example:
https://github.com/elwayman02/ember-resize-modifier/releases/tag/v0.3.0
https://github.com/elwayman02/ember-resize-modifier/blob/master/CHANGELOG.md

This dependency appears to only come from this package:

yarn why highlight.js
yarn why v1.22.15
[1/4] 🤔  Why do we have the module "highlight.js"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "highlight.js@9.18.5"
info Reasons this module exists
   - "release-it-lerna-changelog#lerna-changelog#cli-highlight" depends on it
   - Hoisted from "release-it-lerna-changelog#lerna-changelog#cli-highlight#highlight.js"

lerna-changelog 2.x is already released but has not been upgraded in this package. It depends on cli-highlight 2.x, which depends on v10 of highlight.js.

So, it seems we can fix this issue by bumping this package to 2.x of lerna-changelog.

@rwjblue
Copy link
Collaborator

rwjblue commented Oct 15, 2021

I think this is fixed now (and released in v4)

@rwjblue rwjblue closed this as completed Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants