Fix isIncrement to return only the version requested #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
A few issues that made this take longer than I expected:
strictLatest
seems to cause a failure if the changelog only contains Unreleased. There is even a test case which makes me feel this is intended but it really didn't make any sense. I think this is related to Unclear how should the initial release look like #19 and I've marked the lines that need to be removed. I'd like to note, removing these lines however seems to completely eliminate the usage of strictLatest which I'm not sure why it existsfactory
fromrelease-it/test/util/index.js
doesn't actually setisIncrement
if it's set as an option.isIncrement
is always true no matter what. This is causing the tests to fail. It took me 4 hours to figure out this was my core issue. I spent another hour trying to figure out how to set it and then manually manipulated the variable in memory to make sure my code is good. Without fixing this in the core harness, this code will fail tests.Some thoughts working in this project
# Changelog
prefixedkeepUnreleased
- I thought this would "keep the unreleased title" in the changelog. However it seems to just not version anything which seems to be the same as isIncrement... so should this be deprecated/removed?addUnreleased
- Isn't having an "Unreleased" section part of the https://keepachangelog.com/en/1.0.0/ requirements? So maybe should we just be verifying there is always an unreleased section?I'm going to stop there, anyway just some thoughts for you.