Make npm.timeout configurable

release-it · Aug 25, 2020 · ea3f608 · ea3f608
1 parent 0332981
commit ea3f608
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/config/release-it.json b/config/release-it.json
@@ -24,7 +24,8 @@
     "tag": null,
     "otp": null,
     "ignoreVersion": false,
-    "skipChecks": false
+    "skipChecks": false,
+    "timeout": 10
   },
   "github": {
     "release": false,

diff --git a/lib/plugin/npm/npm.js b/lib/plugin/npm/npm.js
@@ -8,7 +8,6 @@ const prompts = require('./prompts');
 const options = { write: false };
 
 const MANIFEST_PATH = './package.json';
-const REGISTRY_TIMEOUT = 10000;
 const DEFAULT_TAG = 'latest';
 const DEFAULT_TAG_PRERELEASE = 'next';
 const NPM_BASE_URL = 'https://www.npmjs.com';
@@ -27,18 +26,22 @@ class npm extends Plugin {
     const { name, version: latestVersion, private: isPrivate, publishConfig } = require(path.resolve(MANIFEST_PATH));
     this.setContext({ name, latestVersion, private: isPrivate, publishConfig });
 
-    if (this.options.publish === false || isPrivate) return;
+    const { publish, skipChecks } = this.options;
 
-    if (this.options.skipChecks) return;
+    const timeout = Number(this.options.timeout) * 1000;
+
+    if (publish === false || isPrivate) return;
+
+    if (skipChecks) return;
 
     const validations = Promise.all([this.isRegistryUp(), this.isAuthenticated(), this.getLatestRegistryVersion()]);
 
-    await Promise.race([validations, rejectAfter(REGISTRY_TIMEOUT)]);
+    await Promise.race([validations, rejectAfter(timeout)]);
 
     const [isRegistryUp, isAuthenticated, latestVersionInRegistry] = await validations;
 
     if (!isRegistryUp) {
-      throw new Error(`Unable to reach npm registry (timed out after ${REGISTRY_TIMEOUT}ms).`);
+      throw new Error(`Unable to reach npm registry (timed out after ${timeout}ms).`);
     }
 
     if (!isAuthenticated) {