Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return different message when requireCommitsFail is false #1095

Closed
juancarlosjr97 opened this issue Apr 10, 2024 · 1 comment · Fixed by #1101
Closed

Return different message when requireCommitsFail is false #1095

juancarlosjr97 opened this issue Apr 10, 2024 · 1 comment · Fixed by #1101

Comments

@juancarlosjr97
Copy link
Contributor

juancarlosjr97 commented Apr 10, 2024 •
edited

I have been thinking that when git.requireCommitsFail is set to false the message ERROR There are no commits since the latest tag. should not return ERROR but instead should return something else, like INFO.

It fails safe but still keeps the same message which I think is misleading in terms of logs.

Any thoughts?
@webpro
Copy link
Collaborator

webpro commented Apr 18, 2024

I think you're right 💯

Feel free to open a PR for this :)

juancarlosjr97 added a commit to juancarlosjr97/release-it that referenced this issue Apr 20, 2024
@juancarlosjr97
feat: exit without error message when requireCommits is true but requ…
e5f819d 
…ireCommitsFail is false and no commits are available

Fixes release-it#1095
@juancarlosjr97 juancarlosjr97 mentioned this issue Apr 20, 2024
Closed
juancarlosjr97 added a commit to juancarlosjr97/release-it that referenced this issue Apr 20, 2024
@juancarlosjr97
test: add explicit test when requireCommitsFail as true
37021c9 
Fixes release-it#1095
juancarlosjr97 added a commit to juancarlosjr97/release-it that referenced this issue Apr 20, 2024
@juancarlosjr97
test: updating tests by adding default value of requireCommitsFail
c5fe2bb 
Fixes release-it#1095
juancarlosjr97 added a commit to juancarlosjr97/release-it that referenced this issue Apr 20, 2024
@juancarlosjr97
feat: exit without error message when requireCommits is true but requ…
a381972 
…ireCommitsFail is false and no commits are available

Fixes release-it#1095
juancarlosjr97 added a commit to juancarlosjr97/release-it that referenced this issue Apr 25, 2024
@juancarlosjr97
refactor: pass state using error object cause
131df45 
Fixes release-it#1095
@juancarlosjr97 juancarlosjr97 mentioned this issue Apr 25, 2024
Merged
webpro pushed a commit that referenced this issue Apr 26, 2024
@juancarlosjr97
Exit without error message when requireCommits is true but requireCom…
cce35f3 
…mitsFail is false and no commits are available (#1101)

* feat: exit without error message when requireCommits is true but requireCommitsFail is false and no commits are available

Fixes #1095

* refactor: pass state using error object cause

Fixes #1095
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@webpro @juancarlosjr97