Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify as collaborator with GitLab on init doesn't work for inherited members of a project #602

Closed
walokra opened this issue Feb 24, 2020 · 3 comments

Comments

@walokra
Copy link
Contributor

walokra commented Feb 24, 2020

Seems that the changes introduced in Authenticate and verify as collaborator with GitLab on init doesn't return collaborators correctly if project members are defined in group level and are inherited members to the project.

The check is made to project members (GET /projects/:id/members) endpoint which doesn't return all members. The endpoint should be "GET /projects/:id/members/all" which returns all members of a project including inherited members. Or use "GET /projects/:id/members/all/:user_id" directly.

After we updated from 12.4.3 to >=12.5.0 the release-it gives the "is not a collaborator for" error when we run it on GitLab CI pipeline. Our users are defined as group owners and inherited to the project.

@webpro
Copy link
Collaborator

webpro commented Feb 24, 2020

Thanks, @walokra and @ benediktberger!

Could you please try release-it@12.6.2-next.0 and verify it works for inherited members as well?

@benediktberger
Copy link

Ah sorry, didn‘t see this issue although I browsed the issue overview 🤦‍♂

@webpro
Copy link
Collaborator

webpro commented Feb 24, 2020

Actually I was really happy to see a PR for this, thanks for that, Benedikt. But while I was looking at the options I found an alternative which should be faster. Does it work for you now when you npm install release-it@next?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants