You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The "private": true setting in package.json will be respected, and release-it will skip this step.
It seems, however, that this is no longer the case. When I run release-it with the default configuration (publish: true) in a project which has private: true in its package.json, I still see the prompt to publish to npm: ? Publish project-name to npm?
I also found a test for this which does seem to succeed 🤔 . Maybe it doesn't cover the full flow?
Edit: Yup, that seems to be the case. It doesn't actually publish to npm (which is what's tested), but the prompt is still shown, and that part isn't tested AFAIK.
The text was updated successfully, but these errors were encountered:
The automated tests use non-interactive (--ci) runs or otherwise mock Inquirer.js.
I also agree that it doesn't make a lot of sense to prompt for this, so let's keep this issue open for you, someone else or myself to pick up. Or at least improve the docs.
The npm plugin documentation mentions the following:
It seems, however, that this is no longer the case. When I run release-it with the default configuration (publish: true) in a project which has
private: true
in its package.json, I still see the prompt to publish to npm:? Publish project-name to npm?
The init hook does check the private value, but the release hook does not which means the prompt is still triggered.
I also found a test for this which does seem to succeed 🤔 . Maybe it doesn't cover the full flow?
Edit: Yup, that seems to be the case. It doesn't actually publish to npm (which is what's tested), but the prompt is still shown, and that part isn't tested AFAIK.
The text was updated successfully, but these errors were encountered: