Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript errors starting with 15.4.2 #941

Closed
planttheidea opened this issue Sep 22, 2022 · 4 comments · Fixed by #943
Closed

TypeScript errors starting with 15.4.2 #941

planttheidea opened this issue Sep 22, 2022 · 4 comments · Fixed by #943

Comments

@planttheidea
Copy link

planttheidea commented Sep 22, 2022

I use release-it for a number of packages (love it, btw, great work!), and have noticed that if I blindly update to the latest version (15.4.2) I start getting TS errors:

node_modules/@types/cacheable-request/index.d.ts:108:70 - error TS2709: Cannot use namespace 'ResponseLike' as a type.

108         off(event: 'response', listener: (response: ServerResponse | ResponseLike) => void): this;

I also get this if I wipe out my yarn.lock file. meaning it is a nested dependency. Traversing through yarn.lock, I see that @types/cacheable-request seem to be related to got and update-notifier, and since got was updated in the most recent patch, I'm guessing that is the culprit.

Naturally this is an upstream issue, but it is causing pain for consumers of your package. Is it possible that you can pin the version of got until the upstream issue is resolved? I do not get this error on 15.4.1, so my packages are pinned to this version for now.

@johanhammar
Copy link

I'm seeing this as well. Seems related to DefinitelyTyped/DefinitelyTyped#62099 & DefinitelyTyped/DefinitelyTyped#62102

@andreafspeziale
Copy link

andreafspeziale commented Sep 27, 2022

Same problem here while TS building. It should be just a matter of got bumping

npm ls cacheable-request

release-it@15.4.2
  └─┬ got@12.4.1
    └── cacheable-request@7.0.2

Thanks for your hard work!

@Codex-
Copy link
Contributor

Codex- commented Oct 2, 2022

Also requesting that this be bumped as the inclusion of this without allowing minor bumping in the lock causes depending on release-it to pull got@12.4.1 which has this conflict with later typings.

The upstream issue was fixed in got here and has been released already.

@webpro
Copy link
Collaborator

webpro commented Oct 3, 2022

Thanks, everyone. It's in v15.4.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants