Fix timeout issue with 3rd party npm registries. #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasbisdorf
changed the title
|
Thanks, @lukasbisdorf. Could you please add a test for this? I'm happy to merge it then! |
|
Hey @webpro - I'm not sure how to write a proper test inside this test suite. And also not how to reliably test a proper outcome of this function inside a unit test... |
|
No problem, @lukasbisdorf. Would you like me to guide you writing test(s), or would you rather have me do it? I do have some time to write these myself this evening. |
|
For now I would prefer you doing it - I'll than take a look into your code and try to comprehend what you have done. :) |
|
This was just released in v12.4.1. Thanks again, @lukasbisdorf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a Timeout issue when using a 3rd Party NPM registries (JFROG Artifactory).
I noticed that the additional argument
--registryis missing for this check function, so added it in the same fashion as it was made for e.g.isAuthenticated()