Use tag name as version instead of release name #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because GitHub allows name of the release to be anything. It will be better to use tags associated with the releases instead of using the release names. Fixes fedora-infra#845 Signed-off-by: Michal Konečný <mkonecny@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #846 +/- ##
==========================================
+ Coverage 97.32% 97.32% +<.01%
==========================================
Files 61 61
Lines 3664 3667 +3
Branches 496 497 +1
==========================================
+ Hits 3566 3569 +3
Misses 58 58
Partials 40 40
Continue to review full report at Codecov.
|
|
Does that remove this option?
|
No, this only uses name of the tag from which release was created instead of name of the release. I tested it on watchexec and this worked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because GitHub allows name of the release to be anything. It will be
better to use tags associated with the releases instead of using the
release names.
Fixes #845
Signed-off-by: Michal Konečný mkonecny@redhat.com