Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error writing string output #36

Closed
edporras opened this issue Jul 14, 2015 · 5 comments
Closed

Error writing string output #36

edporras opened this issue Jul 14, 2015 · 5 comments

Comments

@edporras
Copy link

Hi Russ,

We've been running into some hangs while writing EDN output with long strings. Reading it is no problem but trying to save it as an EDN file never completes.

Here's a file containing one of these strings:

https://dl.dropboxusercontent.com/u/540179/edn-ruby/long_string.edn

Trying to write it will just hang:

  File.open('./long_string.edn') { |file| data = EDN.read(file) }
  pp data
  File.open('output.edn', 'w') { |file| file.write(data.to_edn) }
@russolsen
Copy link
Member

Ed,

Sorry you are having troubles. I think it is not exactly hanging as it is taking a very long time.

I've just pushed a branch with a fix: faster-string-to-edn. It passes all the tests, but I want to think it through in the daylight before I merge and release.

Again, sorry for the pain.

R

@russolsen
Copy link
Member

ED,

I'd like to add a test for this problem - is it ok if I check in your data?

R

@edporras
Copy link
Author

hey Russ,

Thanks for getting to this so quickly. I checked and it's no problem. Let me know if you push a new version as we could really use it. :)

@russolsen
Copy link
Member

I'm on it.

@russolsen
Copy link
Member

Fixed in version 1.0.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants