Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No set_attributes()/request_set_attributes() Methods #23

Closed
weibullguy opened this issue Aug 16, 2017 · 1 comment
Closed

No set_attributes()/request_set_attributes() Methods #23

weibullguy opened this issue Aug 16, 2017 · 1 comment
Assignees
@weibullguy
Labels
endgame: invalid Issue or PR is closed as not valid. priority: normal Issue or PR is normal priority.

Comments

@weibullguy
Copy link
Collaborator

weibullguy commented Aug 16, 2017 •
edited
Loading

The Revision data model is missing the set_attributes(revision_id, attributes) method and the data controller is missing the corresponding request_set_attributes(revision_id, attributes) method. These methods were added to the base data model and base data controller after the last revision_sprint. They are currently not needed, but should be added in a future sprint.
@weibullguy weibullguy self-assigned this Aug 16, 2017
@weibullguy weibullguy added Module:Revision priority: normal Issue or PR is normal priority. status: backlog Issue or PR is open, unmilestoned, and unassigned. labels Aug 16, 2017
@weibullguy weibullguy added this to the Release 2.0.0rc1 milestone Aug 16, 2017
@weibullguy weibullguy modified the milestones: Release 2.0.0rc1, Release 1.0.0 Nov 27, 2017
@weibullguy weibullguy added status:sprintbacklog and removed status: backlog Issue or PR is open, unmilestoned, and unassigned. labels Jul 17, 2018
@weibullguy weibullguy added status: inprogress Issue or PR is open, milestoned, and assigned. endgame: invalid Issue or PR is closed as not valid. and removed status:sprintbacklog status: inprogress Issue or PR is open, milestoned, and assigned. labels Jul 31, 2018
@weibullguy
Copy link
Collaborator Author

The RTKRevision class contains a get_attributes() and set_attributes() method. The RTKDataController has the request_ methods to call the RTKRevision class attributes. Nothing is needed for this issue and it is being closed with no action taken.

weibullguy added a commit that referenced this issue Jul 31, 2018
@weibullguy
Close get_ and set_attributes() issues for Revision module.
4464fca 
- Close issue #22.
- Close issue #23.
- Update README.md; bullets not formatted correctly.
- Remove print debug cruft.

Signed-off-by: Doyle Rowland <andrew.rowland@reliaqual.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weibullguy weibullguy

Labels
endgame: invalid Issue or PR is closed as not valid. priority: normal Issue or PR is normal priority.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weibullguy