Template customizing #120
Template customizing #120
Conversation
|
By the way, your styleCI service force me to make PSR-12 violation - to remove spaces around concatenating dot:) |
There was a problem hiding this comment.
What is your use case for changing the default templates?
If you're bothered with the timestamps, PR #55 will be included in the next release and you can always import the dev version of the package and use it from now.
config/models.php
Outdated
| @@ -25,7 +25,9 @@ | |||
| | | |||
| */ | |||
|
|
|||
| 'path' => app_path('Models'), | |||
There was a problem hiding this comment.
Please, don't change this line. If you need/want you models to be placed in a different path, you can customise it in your project.
There was a problem hiding this comment.
But why? In Laravel app models are stored and created by default exactly in app directory, not in app/Models.
Maybe it would be more correctly to keep Laravel defaults in default models config?
config/models.php
Outdated
| @@ -38,7 +40,9 @@ | |||
| | | |||
| */ | |||
|
|
|||
| 'namespace' => 'App\Models', | |||
There was a problem hiding this comment.
Same here. Please, don't change this line.
There was a problem hiding this comment.
Same here. In Laravel app models are stored and created by default exactly in App namespase.
https://github.com/laravel/laravel/blob/master/app/User.php
| @@ -280,7 +284,7 @@ | |||
| */ | |||
|
|
|||
| 'except' => [ | |||
| 'migrations', | |||
| 'migrations', 'action_events', 'password_resets', | |||
There was a problem hiding this comment.
Is this table action_events created by Laravel itself?
There was a problem hiding this comment.
Yes of course, it's Laravel service table created by default.
src/Coders/Model/Factory.php
Outdated
| $defaultFile = $this->path([__DIR__, 'Templates', $name]); | ||
| $customTemplatePath = resource_path('generators'); | ||
| $templatePath = file_exists($customTemplatePath) ? $customTemplatePath : __DIR__; | ||
| $defaultFile = $this->path([$templatePath, 'templates', $name]); |
There was a problem hiding this comment.
What is the reasoning behind renaming the Templates folder to templates?
There was a problem hiding this comment.
Usually capitalized names are for directories containig capitalized php classes files, and lower case for directories containing other file which are also in lowercase.
IMHO that looks more consistently.
|
Btw, I'm using Laravel's Style CI configuration in this repository. |
|
My use case for changing the default template is custom phpdocs, codestyle formatting, maybe any coments.. |
|
Do you realise that a custom template wouldn't work without changing the corresponding code inside this package? Let me elaborate a bit, if I were to add a The way I see it, if we want to add some customisation to the model templates, that might need to go through a PR. |
|
Of course new tags will not work without changing the corresponding code inside package. |
|
But probaly you are right, all this is better solved through PR. |
| */ | ||
| public function __construct( | ||
| Fluent $parentCommand, | ||
| Fluent $referenceCommand, | ||
| Model $parent, | ||
| Model $pivot, | ||
| Model $reference | ||
| Model $related |
There was a problem hiding this comment.
Why did you renamed this property? 🤔
There was a problem hiding this comment.
For universality, because in all others relations - this property named 'related'.
I inject trait with comment() getter, who use this property.
Otherwise this trait isn't working and we need add getter in each relation - it will be not DRY:)
|
Thanks for contributing. There are some many changes in this PR. I won't merge it since there are no tests backing us up to see whether something is breaking. |
#119