Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary # from some keys #344

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Remove unnecessary # from some keys #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/memory-profiler.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ And the output is like below. The target process is [psalm](https://github.com/v
"0": {
"#node_id": 1,
"#type": "CallFrameContext",
"#function_name": "Psalm\\IssueBuffer::finish",
"function_name": "Psalm\\IssueBuffer::finish",
"local_variables": {
"#node_id": 2,
"#type": "CallFrameVariableTableContext",
Expand Down
2 changes: 1 addition & 1 deletion src/Lib/PhpProcessReader/PhpMemoryReader/ReferenceContext/CallFrameContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public function __construct(
public function getContexts(): iterable
{
return [
'#function_name' => $this->function_name,
'function_name' => $this->function_name,
];
}
}
2 changes: 1 addition & 1 deletion src/Lib/PhpProcessReader/PhpMemoryReader/ReferenceContext/ScalarValueContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public function __construct(
public function getContexts(): iterable
{
return [
'#value' => $this->value,
'value' => $this->value,
];
}
}
12 changes: 6 additions & 6 deletions tests/Lib/PhpProcessReader/PhpMemoryReader/MemoryLocationsCollectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ public function wait($input): void {
);
$this->assertSame(
'fgets',
$contexts_analyzed['call_frames']['0']['#function_name']
$contexts_analyzed['call_frames']['0']['function_name']
);
$this->assertSame(
'ResourceContext',
Expand All @@ -212,7 +212,7 @@ public function wait($input): void {
['array_elements']
['dynamic_property']
['value']
['#value']
['value']
);
$this->assertSame(
123,
Expand All @@ -224,7 +224,7 @@ public function wait($input): void {
['array_elements']
['0']
['value']
['#value']
['value']
);
$this->assertSame(
456,
Expand All @@ -235,11 +235,11 @@ public function wait($input): void {
['array_elements']
['extra']
['value']
['#value']
['value']
);
$this->assertSame(
'A::wait',
$contexts_analyzed['call_frames']['2']['#function_name']
$contexts_analyzed['call_frames']['2']['function_name']
);
$this->assertSame(
$contexts_analyzed['call_frames']['3']['symbol_table']['array_elements']['object']['value']['#node_id'],
Expand Down Expand Up @@ -288,7 +288,7 @@ public function wait($input): void {
['array_elements']
['test_static_variable']
['value']
['#value']
['value']
);
$this->assertSame(
1,
Expand Down
Loading