Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first search result row is partially hidden under the top menu #74

Closed
dassencio opened this issue Oct 25, 2016 · 5 comments
Closed

first search result row is partially hidden under the top menu #74

dassencio opened this issue Oct 25, 2016 · 5 comments
Assignees
Labels
Milestone

Comments

@dassencio
Copy link

Expected behavior

First search result row is entirely visible.

Actual behavior

First search result row is partially hidden under the top menu.

Steps to reproduce the behavior

  1. Type a string on the search box which matches the name of one or more songs in the music collection
  2. Each matching song name is displayed as a row (to be specific, as a td element of class 'info')
  3. The row containing the first song name is partially hidden under the top menu, and the song name itself (a div of class 'name result') appears to be directly touching the ownCloud top menu.

Possible solution (optional)

Properly align the table containing the search results so that its first row does not partially hide under the top menu.

Server configuration

Operating system:
Linux

Web server:
apache

Database:
sqlite

PHP version:
7.0

ownCloud/Nextcloud version: (see /status.php)
9.1.0

Updated from an older ownCloud/Nextcloud or fresh install:
Fresh install

Where did you install Audio Player from:
Apps menu (as admin)

Are you using external storage, if yes which one: local/smb/sftp/...
No

Are you using encryption: yes/no
Yes

Client configuration

Operating system:
Linux

Browser:
Firefox and Chrome

Logs

ownCloud/Nextcloud log

ownCloud/Nextcloud log (/data/[owncloud|nextcloud].log)

Insert your ownCloud/Nextcloud log here
#### Web server error log (optional)

Web server error log

Insert your webserver log here
#### Browser log (optional)

Browser log

Insert your browser log here
@dassencio dassencio changed the title First song search result row is partially hidden under the ownCloud top menu First song in search results has its row partially hidden under the ownCloud top menu Oct 25, 2016
@dassencio
Copy link
Author

After further investigation, I realized that the search box is not part of the Audio Player, but of ownCloud itself. However, this search box does not seem to properly interact with the Audio Player at all. It would be great if you could improve this, but if not, then just close this issue. Thank you very much!

@Rello Rello self-assigned this Nov 7, 2016
@Rello Rello added the needs info feedback from requester required label Nov 7, 2016
@Rello
Copy link
Owner

Rello commented Nov 7, 2016

Hello @dassencio
I just tried to understand the issue. I could not replicate the problem.
could you post a screenshot please?

Even so I am not sure if I can influence it, because the api for handing over search-results is pretty straight forward, I would like to double check.

thank you

@dassencio
Copy link
Author

Hi @Rello

Please see the attached screenshot. Take a look at the very first row in the results: do you see that the row is partially hidden by the top menu?

Thank you very much!

screenshot

@Rello Rello added bug and removed needs info feedback from requester required labels Nov 8, 2016
@Rello Rello added this to the 1.3 milestone Nov 8, 2016
@Rello
Copy link
Owner

Rello commented Nov 8, 2016

I found something strange on #searchresults within result.css of the search functionality.
I need to check if it related to Audio Player stylesheet

@Rello Rello removed this from the 1.3 milestone Nov 14, 2016
@ghost ghost added the design label Nov 18, 2016
@ghost ghost changed the title First song in search results has its row partially hidden under the ownCloud top menu First search result row is partially hidden under the top menu Nov 18, 2016
@Rello Rello added this to the 1.4.0 milestone Dec 3, 2016
@Rello
Copy link
Owner

Rello commented Dec 3, 2016

Issue located.
search result will be shown above album container now
screen shot 2016-12-03 at 18 42 27

Rello added a commit that referenced this issue Dec 3, 2016
Rello added a commit that referenced this issue Dec 3, 2016
@Rello Rello changed the title First search result row is partially hidden under the top menu fix: first search result row is partially hidden under the top menu Dec 3, 2016
Rello added a commit that referenced this issue Dec 5, 2016
fix: catch special characters in album #87
fix: occ catch unknown user #93
fix: correct album sort order to case-insensitive
fix: first search result row is partially hidden under the top menu #74
enhancement: Ukrainian translation #94
enhancement: folders as additional filter category #98
enhancement: search for cover in album folder #24
enhancement: Opus support #92
@ghost ghost removed the pending release label Dec 15, 2016
@ghost ghost closed this as completed Dec 15, 2016
@ghost ghost changed the title fix: first search result row is partially hidden under the top menu first search result row is partially hidden under the top menu Feb 12, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants