-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port keybindings and supports. #1566
base: master
Are you sure you want to change the base?
Conversation
Move initially defined keybindings to Rust. Use 'AsRef' Trait to make keybinding definition more hygienic. Along with 'KeyChar' the need for casting is contained within 'initially_defined_key'.
@@ -5466,9 +5466,15 @@ fi || AC_MSG_ERROR(['src/epaths.h' could not be made.]) | |||
|
|||
|
|||
CARGO_DEFAULT_FEATURES="" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were added to allow all of the keybindings to be ported.
@@ -1756,17 +1758,6 @@ pub extern "C" fn reset_buffer_local_variables(mut buffer: LispBufferRef, includ | |||
buffer.reset_local_variables(include_permanent) | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code was moved to the end to make it easier to find.
@@ -1982,4 +1973,23 @@ pub fn byte_char_debug_check(b: LispBufferRef, charpos: isize, bytepos: isize) { | |||
} | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KeyChar
here is saving us from casting between chars, u8, and EmacsInt.
@@ -262,37 +264,6 @@ pub fn recursive_edit() { | |||
} | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solely a move for easier managing.
@@ -5278,12 +5278,14 @@ Functions running this hook are, `get-buffer-create', | |||
Fput (intern_c_string ("erase-buffer"), Qdisabled, Qt); | |||
} | |||
|
|||
#ifdef IGNORE_RUST_PORT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is never defined. But it makes merges from emacs easier. No more missing functions.
Move initially defined keybindings to Rust.
Use 'AsRef' Trait to make keybinding definition more hygienic.
Along with 'KeyChar' the need for casting is contained within
'initially_defined_key'.