Optimize list UI drawer #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into optimize-list-ui-drawer
…g it easier to understand and faster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I focus on getting the ListUI to be faster and we should not have to rely on not being updated/draw when not mouse over because that makes it not work as well.
I updates the image every frame but since it is cached it should go fast.
Having a cache method have forced me to refactor the code a lot. I must based the cache on values so I broken down the calculations in pure methods.
Also a lot of changes are due to autopep8.
I still see improvements to be done to the list but I think I rather fix those next time I implement a new thing in the list.