Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(package): upgrade domhandler to v4 and htmlparser2 to v6 #45

Merged
merged 1 commit into from
Dec 25, 2020

Conversation

remarkablemark
Copy link
Owner

What is the motivation for this pull request?

BREAKING CHANGE: upgrade domhandler to v4 and htmlparser2 to v6

 domhandler   3.3.0  →  4.0.0
 htmlparser2  4.1.0  →  6.0.0

domhandler:

htmlparser2:

decodeEntities option now defaults to true. <title> is parsed correctly. Remove root parent node to keep parser backwards compatible.

Checklist:

  • Tests
  • Types
  • Documentation

BREAKING CHANGE: upgrade `domhandler` to v4 and `htmlparser2` to v6

 domhandler   3.3.0  →  4.0.0
 htmlparser2  4.1.0  →  6.0.0

domhandler:

* https://github.com/fb55/domhandler/releases/tag/v4.0.0

htmlparser2:

* https://github.com/fb55/htmlparser2/releases/tag/v5.0.0
* https://github.com/fb55/htmlparser2/releases/tag/v5.0.1
* https://github.com/fb55/htmlparser2/releases/tag/v6.0.0

`decodeEntities` option now defaults to true. `<title>` is
parsed correctly. Remove root parent node to keep parser
backwards compatible.
@remarkablemark remarkablemark added the dependencies Pull requests that update a dependency file label Dec 24, 2020
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-dom-parser.min.js 2.67 KB (+8.12% 🔺) 54 ms (+8.12% 🔺) 96 ms (+4.37% 🔺) 150 ms

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 88.546% when pulling ec5673e on build/dependencies into f8b0749 on master.

@remarkablemark remarkablemark merged commit 74811a3 into master Dec 25, 2020
@remarkablemark remarkablemark deleted the build/dependencies branch December 25, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants