Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including license in NPM package #124

Closed
paulbarmstrong opened this issue Mar 24, 2024 · 4 comments · Fixed by #125 or #126
Closed

Including license in NPM package #124

paulbarmstrong opened this issue Mar 24, 2024 · 4 comments · Fixed by #125 or #126
Assignees

Comments

@paulbarmstrong
Copy link

Problem

While scanning my dependencies I found that the inline-style-parser NPM package doesn't include a license. I saw from the README that this project uses an instance of the MIT license from another repo. Given that this license requires that it be included in all copies or substantial portions of the Software, I think it may make sense for the license to be included in the NPM package.

Suggested Solution

I suggest adding the license as a file in this repo, and allowing that to be published to the NPM package. I think most NPM packages already include their license.

Keywords

license

@remarkablemark
Copy link
Owner

@paulbarmstrong would you like to open a PR?

@paulbarmstrong
Copy link
Author

I wouldn't mind opening a PR but I'm not quite sure how the license should be. Should it use the same license from reworkcss that gives copyright to TJ Holowaychuk?

@remarkablemark
Copy link
Owner

I opened a PR #125

@remarkablemark
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants