fix(parser): do not add to output if css value is empty

Update tests with invalid and error cases.
remarkablemark · Nov 17, 2017 · 0759da7 · 0759da7
1 parent d7e0450
commit 0759da7
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 4 deletions.
diff --git a/index.js b/index.js
@@ -16,7 +16,10 @@ module.exports = function parseInlineStyleServer(style) {
   var output = {};
 
   declarations.forEach(function(declaration) {
-    output[declaration.property] = declaration.value;
+    var value = declaration.value;
+    if (value) {
+      output[declaration.property] = value;
+    }
   });
 
   return output;

diff --git a/test/cases.js b/test/cases.js
@@ -97,6 +97,18 @@ const styles = [
       display: 'flex',
     },
   },
+
+  // missing value
+  {
+    style: 'z-index:',
+    expected: {},
+  },
+
+  // missing property
+  {
+    style: ': 42',
+    expected: Error,
+  },
 ];
 
 module.exports = {

diff --git a/test/index.js b/test/index.js
@@ -6,10 +6,19 @@ const parser = require('../')
 
 describe('parser', () => {
   cases.default.forEach(({ style, expected }) => {
+
     describe(`when style=\`${style}\``, () => {
-      it(`returns ${JSON.stringify(expected)}`, () => {
-        assert.deepEqual(parser(style), expected);
-      });
+      if (expected === Error) {
+        it('throws error', () => {
+          assert.throws(() => parser(style), Error);
+        });
+
+      } else {
+        it(`returns ${JSON.stringify(expected)}`, () => {
+          assert.deepEqual(parser(style), expected);
+        });
+      }
     });
+
   });
 });