Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types #616

Merged
merged 1 commit into from Jul 9, 2021
Merged

Fix types #616

merged 1 commit into from Jul 9, 2021

Conversation

ChristianMurphy
Copy link
Member

adds checks to ast-to-react to handle edge cases with Root node possibly being a parent.
update test cases to narrow typings where needed.

@ChristianMurphy ChristianMurphy added 🕸️ area/tests This affects tests ☂️ area/types This affects typings labels Jul 9, 2021
@codecov-commenter

This comment has been minimized.

Sign in to view
@ChristianMurphy ChristianMurphy added 👶 semver/patch This is a backwards-compatible fix 🏡 area/internal This affects the hidden internals labels Jul 9, 2021
@ChristianMurphy ChristianMurphy requested a review from a team July 9, 2021 17:35
@wooorm wooorm changed the title test: fix typescript typings in tests Fix types Jul 9, 2021
@wooorm wooorm merged commit 456bb3b into remarkjs:main Jul 9, 2021
@ChristianMurphy ChristianMurphy deleted the test/fix-typings-in-tests branch July 9, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

Assignees
No one assigned
Labels
🏡 area/internal This affects the hidden internals 🕸️ area/tests This affects tests ☂️ area/types This affects typings 👶 semver/patch This is a backwards-compatible fix
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ChristianMurphy @codecov-commenter @wooorm