Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated and unneeded defaultProps #718

Closed
wants to merge 0 commits into from

Conversation

Lepozepo
Copy link
Contributor

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Seeing a deprecation warning with defaultProps but for some reason this didn't actually remove it in my environment. Regardless, this is a safer bet

TODO

@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Dec 11, 2022
@github-actions

This comment has been minimized.

@wooorm
Copy link
Member

wooorm commented Dec 12, 2022

  • PR info not filled out
  • No test
  • Build fails
  • We already support no defaultProps:
    if (name === 'a' && options.transformLinkUri) {
  • “for some reason this didn't actually remove it in my environment” sounds like this doesn’t solve your original question

@Lepozepo
Copy link
Contributor Author

@wooorm ah, yeah, I was just going through it quickly and didn't really look at or test anything. More than anything wanted to bring the warning to light. I'll see if I can make a bit of time tonight to play around with the anchor tag, sounds like maybe I messed something up on my end to trigger the warning on the a tag

@wooorm
Copy link
Member

wooorm commented Dec 13, 2022

Maybe better to post the problem you ran into?

@Lepozepo
Copy link
Contributor Author

@wooorm seeing this in a nextjs app

Screenshot 2022-12-13 at 8 26 42 AM

@actraiser
Copy link

Seeing the same error in nextjs 13

lib/react-markdown.js Outdated Show resolved Hide resolved
@wooorm wooorm changed the title Patch deprecated defaultValues Remove deprecated and unneeded defaultProps Dec 15, 2022
@github-actions

This comment has been minimized.

wooorm pushed a commit that referenced this pull request Dec 15, 2022
@wooorm
Copy link
Member

wooorm commented Dec 15, 2022

Thanks!

@wooorm wooorm added the 💪 phase/solved Post is done label Dec 15, 2022
@github-actions github-actions bot removed the 👋 phase/new Post is being triaged automatically label Dec 15, 2022
@william-liebenberg
Copy link

hi all, when would this build get released? im getting this exact error :)

@wooorm
Copy link
Member

wooorm commented Jan 3, 2023

Soon. It’s a warning

@william-liebenberg
Copy link

Thanks @wooorm :)

@santigandolfo
Copy link

Hi! I'm still viewing this warning.
Do we have an ETA on when it will be "fixed"? Is there a way to supress it?
Thansk!

@ChristianMurphy
Copy link
Member

ChristianMurphy commented Feb 15, 2023

It is fixed and released, please update the version of react-markdown to latest (8.0.5 at the time of writing)

@remarkjs remarkjs locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants