-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mailto links (weird behavior) #9
Comments
Currently, any URL that starts with a protocol is seen as external (through here and here). We can go two ways: see every protocol except mailto as absolute, or see only http / https as absolute. What are your thoughts, and benefits / tradeoffs? /cc @makenowjust (last person to touch that line) |
Hey @wooorm appreciate the quick reply as always. I could see this being a compounding issue for protocols like Do you think it'd be worth trying to "whitelist" those in that list? I can't personally think of a time you'd want to have any of those protocols open up a new tab, but I'm not familiar with a bunch of 'em. |
I’m not really into adding a big list here 😕 So I’m up for allowing just http / https. But I can see potential exceptions in the future (about? blob? more?). Or just ignoring mailto for now and seeing where that goes? |
Yeah maybe just checking for |
/cc also maybe @xuopled or @fand have thoughts on this |
Only Chrome (and Chromium family browsers like Vivaldi) remains a blank tab after clicking a I think it is Chrome's problem, however treating only |
Hmm, also like to add that people can set up |
While I do agree there can be different cases for protocol URLs, I myself have never seen a |
How about the following pseudo-code changes?
...that would allow people to still specify their own protocols. @zslabs Want to write a PR for this, with tests? |
It sounds good to me @wooorm |
Just created #10 let me know what you think. Thanks! |
Currently links that start with
mailto:
have the external link options applied; which is an odd behavior as when clicked the mail client is opened, but a blank tab is shown in the browser.The text was updated successfully, but these errors were encountered: