Add protocols option to bypass is-absolute package regex #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooorm
requested changes
Jan 4, 2019
Co-Authored-By: zslabs <info@zslabs.com>
This comment has been minimized.
This comment has been minimized.
|
Thanks for the review! I've pushed an update that pulls out the protocol into its own variable; for some reason it's getting confused when thrown in with the |
wooorm
approved these changes
Jan 4, 2019
wooorm
added
⛵️ status/released
🗄 area/interface
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #9
Was getting some false-positives with the
indexOfexample provided; any issue with going withincludes()?Thanks!