Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contentProperties option #16

Merged
merged 2 commits into from
Jun 8, 2020
Merged

Add contentProperties option #16

merged 2 commits into from
Jun 8, 2020

Conversation

iloveip
Copy link
Contributor

@iloveip iloveip commented Jun 8, 2020

Address #15

@codecov-commenter

This comment has been minimized.

Sign in to view
@wooorm
Copy link
Member

wooorm commented Jun 8, 2020

Super nice, awesome Svetlana! ✨

I do have a hunch that our tooling will change some of the code-style, namely, wrap the line.

Can you try npm install locally, to install dependencies, and then do npm test? That should make sure that everything is formatted, checked, and tested locally.

If that doesn’t change anything, it’s perfect, and ready to go!

@iloveip
Copy link
Contributor Author

iloveip commented Jun 8, 2020

Thank you for your help) I pushed an update.

@wooorm wooorm changed the title Added contentProperties to span Add contentProperties option Jun 8, 2020
@wooorm wooorm merged commit 41b04df into remarkjs:master Jun 8, 2020
@wooorm wooorm mentioned this pull request Jun 8, 2020
Closed
@wooorm
Copy link
Member

wooorm commented Jun 8, 2020

Thanks, released!

In the future, it’s a good idea to add docs and tests to new features.

Congrats on & thanks for your contribution!

@wooorm wooorm added ⛵️ status/released 🗄 area/interface This affects the public interface 🦋 type/enhancement This is great to have 🧒 semver/minor This is backwards-compatible change labels Jun 8, 2020
@iloveip
Copy link
Contributor Author

iloveip commented Jun 8, 2020

Ok, thank you very much 🙏

@wooorm wooorm added the 💪 phase/solved Post is done label Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iloveip @codecov-commenter @wooorm