Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for changes in remark #2

Merged
merged 5 commits into from
May 30, 2018
Merged

Update for changes in remark #2

merged 5 commits into from
May 30, 2018

Conversation

fand
Copy link
Contributor

@fand fand commented Mar 6, 2018 •
edited
Loading

ref. #1

This PR fixes API changes introduced by latest version of remark.

Changes

  • Update remark, remark-html in devDependencies
  • Fixed the order of params
  • Fixed tests with async/await for promises returned by .process()
  • Update Node.js on Travis CI to support async/await

@fand fand changed the title Update for chanes in remark Update for changes in remark Mar 6, 2018
@h-michael
Copy link

@xuopled
Could you review and merge this PR?

@cedricdelpoux
Copy link

Thank you @h-michael for your work

@cedricdelpoux cedricdelpoux merged commit 5ff1226 into remarkjs:master May 30, 2018
@cedricdelpoux
Copy link

I published v2.0.0

@h-michael
Copy link

@xuopled Thank you for taking your precious time for me.
@fand Thank you for your pr.

@cedricdelpoux
Copy link

You were right to relaunch me. I completely missed the PR

@wooorm wooorm added ⛵️ status/released 📦 area/deps This affects dependencies 🦋 type/enhancement This is great to have 🧑 semver/major This is a change labels Aug 14, 2019
@wooorm wooorm added the 💪 phase/solved Post is done label Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
📦 area/deps This affects dependencies 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fand @h-michael @cedricdelpoux @wooorm