Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types #4

Merged
merged 5 commits into from Aug 22, 2020
Merged

Add types #4

merged 5 commits into from Aug 22, 2020

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented Jul 30, 2020

No description provided.

@codecov-commenter

This comment has been minimized.

Sign in to view
ChristianMurphy
ChristianMurphy approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pd4d10! 🙇

types/index.d.ts Outdated Show resolved Hide resolved
@ChristianMurphy ChristianMurphy added ☂️ area/types This affects typings 🦋 type/enhancement This is great to have 🧑 semver/major This is a change labels Jul 30, 2020
@pd4d10 @ChristianMurphy
Update types/index.d.ts
c0445f4 
Co-authored-by: Christian Murphy <christian.murphy.42@gmail.com>
@ChristianMurphy ChristianMurphy requested a review from a team July 30, 2020 13:12
@ChristianMurphy ChristianMurphy requested a review from a team August 19, 2020 17:18
@wooorm wooorm merged commit 020aa32 into remarkjs:main Aug 22, 2020
@wooorm
Copy link
Member

wooorm commented Aug 22, 2020

Thanks @pd4d10! Released in 2.0.0!

@ChristianMurphy ChristianMurphy mentioned this pull request Feb 7, 2021
Merged
This was referenced May 11, 2021
Closed
Closed
@wooorm wooorm mentioned this pull request Jun 7, 2021
Closed
@wooorm wooorm added the 💪 phase/solved Post is done label Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

@BarryThePenguin BarryThePenguin BarryThePenguin approved these changes

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@Rokt33r Rokt33r Rokt33r approved these changes

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pd4d10 @codecov-commenter @wooorm @BarryThePenguin @ChristianMurphy @Rokt33r