Regex is incorrect (does not accurately parse GitHub usernames)

[niftylettuce]

I get the following error with the following package.json "repository" field:

CHANGELOG.md
  1:1  error  Error: Missing `repository` field in `options`
    at Function.github (/Users/user/Projects/color-convert/node_modules/remark-github/lib/index.js:76:11)

Repository value: https://github.com/Qix-/color-convert

I believe the trailing - on the username is causing it to fail.

[wooorm]

Weird!

I guess they changed that later? Do you know of any other guideline where GH themselves parse handles?

[niftylettuce]

No idea

…

On Wed, Jun 20, 2018, 12:45 PM Titus ***@***.***> wrote: Weird! [image: screen shot 2018-06-20 at 19 44 57] <https://user-images.githubusercontent.com/944406/41675248-761b49e0-74c2-11e8-98b4-bdb1bf4ef3f3.png> I guess they changed that later? Do you know of any other guideline where GH themselves parse handles? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#13 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAf7hRDaIDVI6ODBAF_Al9WmrYvNMPwAks5t-opVgaJpZM4Uvsxk> .

[wooorm]

https://github.com/shinnn/github-username-regex/issues/1

Feel free to submit a PR