Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maximum-line-length: fix long links #319

Merged
merged 1 commit into from
Apr 17, 2024
Merged

maximum-line-length: fix long links #319

merged 1 commit into from
Apr 17, 2024

Conversation

Trott
Copy link
Contributor

@Trott Trott commented Apr 17, 2024

Fixes: #318

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Fixes maximum line length calculation bug in #318.

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Apr 17, 2024
@wooorm
Copy link
Member

wooorm commented Apr 17, 2024

I’ll go with this and fiddle some more, including with the examples shown on the other thread! Thanks!

@wooorm wooorm changed the title Fix line length calculation bug with links in paragraph maximum-line-length: fix long links Apr 17, 2024
@wooorm wooorm merged commit 159d927 into remarkjs:main Apr 17, 2024
5 checks passed
@wooorm wooorm added the 💪 phase/solved Post is done label Apr 17, 2024

This comment has been minimized.

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Apr 17, 2024
@wooorm
Copy link
Member

wooorm commented Apr 17, 2024

OK I think this patch was fundamentally wrong, but still very close: the [\t ] check was indeed naïve. Added a bunch of tests and a different algo!

@wooorm
Copy link
Member

wooorm commented Apr 17, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

remark-lint-maximum-line-length changes
2 participants