Skip to content

Commit

Permalink
Make test concise
Browse files Browse the repository at this point in the history
  • Loading branch information
jablko committed Feb 9, 2022
1 parent f69de04 commit 933152c
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 29 deletions.
1 change: 1 addition & 0 deletions lib/find/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export function config(ctx) {
if (info.type in viewPaths) {
urlConfig.prefix =
new URL(info.browse({treepath: viewPaths[info.type]})).pathname + '/'
// GitHost#browse() omits the "blob" segment from branch-less URLs.
if (!info.committish) {
urlConfig.prefix += viewPaths[info.type] + '/'
}
Expand Down
8 changes: 8 additions & 0 deletions test/fixtures/other-branches.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Links to other branches

- [Same branch, working link](https://github.com/wooorm/test/blob/main/examples/github.md#hello).
- [Other branch, working link](https://github.com/wooorm/test/blob/foo-bar/examples/github.md#hello): Nothing to ignore.
- [Same branch, unknown heading](https://github.com/wooorm/test/blob/main/examples/github.md#world): Should be reported.
- [Other branch, unknown heading](https://github.com/wooorm/test/blob/foo-bar/examples/github.md#world): Should be ignored.
- [Same branch, unknown file](https://github.com/wooorm/test/blob/main/examples/world.md#hello): Should be reported.
- [Other branch, unknown file](https://github.com/wooorm/test/blob/foo-bar/examples/world.md#hello): Should be ignored.
35 changes: 6 additions & 29 deletions test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -1017,41 +1017,18 @@ test('links to other branches', async (t) => {
'"../../index.js=repository:\\"wooorm/test#main\\""',
'--use',
'../sort.js',
'github.md',
'examples/github.md'
'other-branches.md'
].join(' ')
)
t.deepEqual(
strip(stderr),
[
'examples/github.md',
' 5:37-5:51 warning Link to unknown heading: `world` missing-heading remark-validate-links',
' 15:34-15:91 warning Link to unknown file: `../world.md` missing-file remark-validate-links',
' 19:10-19:29 warning Link to unknown file: `../world.md` missing-file remark-validate-links',
' 29:10-29:33 warning Link to unknown heading in `../github.md`: `world` missing-heading-in-file remark-validate-links',
' 31:10-31:71 warning Link to unknown heading in `../github.md`: `world` missing-heading-in-file remark-validate-links',
' 35:10-35:32 warning Link to unknown file: `../world.md` missing-file remark-validate-links',
' 35:10-35:32 warning Link to unknown heading in `../world.md`: `hello` missing-heading-in-file remark-validate-links',
' 37:10-37:70 warning Link to unknown file: `../world.md` missing-file remark-validate-links',
' 37:10-37:70 warning Link to unknown heading in `../world.md`: `hello` missing-heading-in-file remark-validate-links',
'',
'github.md',
' 5:37-5:51 warning Link to unknown heading: `world` missing-heading remark-validate-links',
' 21:34-21:100 warning Link to unknown file: `examples/world.md` missing-file remark-validate-links',
' 23:34-23:82 warning Link to unknown file: `examples/world.md` missing-file remark-validate-links',
' 27:10-27:37 warning Link to unknown file: `examples/world.md` missing-file remark-validate-links',
' 29:10-29:35 warning Link to unknown file: `examples/world.md` missing-file remark-validate-links',
' 41:10-41:41 warning Link to unknown heading in `examples/github.md`: `world` missing-heading-in-file remark-validate-links',
' 43:10-43:39 warning Link to unknown heading in `examples/github.md`: `world` missing-heading-in-file remark-validate-links',
' 45:10-45:80 warning Link to unknown heading in `examples/github.md`: `world` missing-heading-in-file remark-validate-links',
' 49:10-49:40 warning Link to unknown file: `examples/world.md` missing-file remark-validate-links',
' 49:10-49:40 warning Link to unknown heading in `examples/world.md`: `hello` missing-heading-in-file remark-validate-links',
' 51:10-51:38 warning Link to unknown file: `examples/world.md` missing-file remark-validate-links',
' 51:10-51:38 warning Link to unknown heading in `examples/world.md`: `hello` missing-heading-in-file remark-validate-links',
' 53:10-53:79 warning Link to unknown file: `examples/world.md` missing-file remark-validate-links',
' 53:10-53:79 warning Link to unknown heading in `examples/world.md`: `hello` missing-heading-in-file remark-validate-links',
'other-branches.md',
' 5:3-5:100 warning Link to unknown heading in `examples/github.md`: `world` missing-heading-in-file remark-validate-links',
' 7:3-7:96 warning Link to unknown file: `examples/world.md` missing-file remark-validate-links',
' 7:3-7:96 warning Link to unknown heading in `examples/world.md`: `hello` missing-heading-in-file remark-validate-links',
'',
'⚠ 23 warnings',
'⚠ 3 warnings',
''
].join('\n'),
'should ignore links to other branches'
Expand Down

0 comments on commit 933152c

Please sign in to comment.