Fix warning for impossible directories

Closes GH-54.
remarkjs · Jun 11, 2020 · cc4c1b3 · oleorhagen · Jun 11, 2020 · wooorm
1 parent f3a325b
commit cc4c1b3
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 1 deletion.
diff --git a/lib/check/check-files.js b/lib/check/check-files.js
@@ -30,7 +30,7 @@ function checkIfReferencedFilesExist(ctx, next) {
     fs.access(filePath, fs.F_OK, onaccess)
 
     function onaccess(err) {
-      var noEntry = err && err.code === 'ENOENT'
+      var noEntry = err && (err.code === 'ENOENT' || err.code === 'ENOTDIR')
 
       landmarks[filePath] = {'': !noEntry}
 

diff --git a/test/fixtures/file-as-folder.md b/test/fixtures/file-as-folder.md
@@ -0,0 +1 @@
+[](file-as-folder.md/other)
diff --git a/test/index.js b/test/index.js
@@ -1043,6 +1043,41 @@ test('remark-validate-links', function (t) {
     }
   })
 
+  t.test('should warn on files as folders', function (st) {
+    st.plan(1)
+
+    childProcess.exec(
+      [
+        bin,
+        '--no-config',
+        '--no-ignore',
+        '--use',
+        '../..',
+        '--use',
+        '../sort',
+        'file-as-folder.md'
+      ].join(' '),
+      onexec
+    )
+
+    function onexec(err, stdout, stderr) {
+      st.deepEqual(
+        [err, strip(stderr)],
+        [
+          null,
+          [
+            'file-as-folder.md',
+            '  1:1-1:28  warning  Link to unknown file: `file-as-folder.md/other`. Did you mean `file-as-folder.md`  missing-file  remark-validate-links',
+            '',
+            '⚠ 1 warning',
+            ''
+          ].join('\n')
+        ],
+        'should work'
+      )
+    }
+  })
+
   t.test('should check images', function (st) {
     st.plan(1)