Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gfm: literal email parsing is incorrect #475

Closed
wooorm opened this issue Mar 23, 2020 · 0 comments · Fixed by #479
Closed

gfm: literal email parsing is incorrect #475

wooorm opened this issue Mar 23, 2020 · 0 comments · Fixed by #479
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done remark-parse 👶 semver/patch This is a backwards-compatible fix

Comments

@wooorm
Copy link
Member

wooorm commented Mar 23, 2020

Subject of the issue

Literal email addresses, a feature of GFM, aren’t parsed correctly.

Your environment

n/a

Steps to reproduce

example1 (1234567@example.com)
example1 (mailto:1234567@example.com)

Expected behaviour

example1 (1234567@example.com)
example1 (mailto:1234567@example.com)

Actual behaviour

The first is not linked, the second is completely linked.
@wooorm wooorm added 👶 semver/patch This is a backwards-compatible fix remark-parse 🗄 area/interface This affects the public interface 🙆 yes/confirmed This is confirmed and ready to be worked on labels Mar 23, 2020
@wooorm wooorm mentioned this issue Mar 23, 2020
Closed
wooorm added a commit that referenced this issue Mar 27, 2020
@wooorm
parse: add support for emails without protocol
a2f5eb4 
Closes GH-475.
@wooorm wooorm mentioned this issue Mar 27, 2020
Merged
wooorm added a commit that referenced this issue Mar 29, 2020
@wooorm
parse: add support for emails without protocol
f598a3e 
Closes GH-475.
wooorm added a commit that referenced this issue Mar 29, 2020
@wooorm
parse: add support for emails without protocol
0cec4d8 
Closes GH-475.
Closes GH-479.
@wooorm wooorm added ⛵️ status/released and removed 🙆 yes/confirmed This is confirmed and ready to be worked on labels Mar 30, 2020
@trieloff trieloff mentioned this issue Apr 2, 2020
Merged
1 task
@azu azu mentioned this issue May 12, 2021
Merged
4 tasks
@wooorm wooorm added the 💪 phase/solved Post is done label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done remark-parse 👶 semver/patch This is a backwards-compatible fix
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

parse: add support for emails without protocol remarkjs/remark
1 participant
@wooorm