Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remark-utf8s and remark-code-screenshot to list of plugins #381

Merged
merged 2 commits into from Jan 21, 2019

Conversation

Swizec
Copy link
Contributor

@Swizec Swizec commented Jan 10, 2019

Hi 👋

I just created two small plugins for Remark and thought they'd fit your list of existing plugins.

@sobolevn
Copy link
Member

@Swizec please, address these issues:

doc/plugins.md
    42:5-42:54  warning  Marker style should be `*`                unordered-list-marker-style  remark-lint
          42:7  warning  Incorrect list-item indent: add 2 spaces  list-item-indent             remark-lint
  180:5-180:66  warning  Marker style should be `*`                unordered-list-marker-style  remark-lint
         180:7  warning  Incorrect list-item indent: add 2 spaces  list-item-indent             remark-lint

@Swizec
Copy link
Contributor Author

Swizec commented Jan 21, 2019

@sobolevn I copied that from the other lines and just verified with GitHub's online editor that it is exactly the same.

I don't know how else to fix it.

@Murderlon Murderlon merged commit cf52183 into remarkjs:master Jan 21, 2019
@wooorm
Copy link
Member

wooorm commented Jan 22, 2019

Problem was that you typed them over, and there’s a slight difference between the normal dash (-) that starts a list item and an em-dash (—), used to delimit the plugin from the description, which you don’t really see in monospace.

Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants