Add missing type to typescript .d.ts #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`RemarkParser` does have `blockTokenizers` but it's missing here.
ChristianMurphy
requested changes
Jul 19, 2020
There was a problem hiding this comment.
Thanks @CNLHC!
Having the block tokenizers is a good addition.
I added a few comments below:
ChristianMurphy
added
☂️ area/types
|
Done. \cc @ChristianMurphy maybe you can merge it now. |
ChristianMurphy
approved these changes
Jul 21, 2020
Rokt33r
approved these changes
Jul 22, 2020
|
@ChristianMurphy Will this be released released as a stable version for 8.0? |
|
I'm not sure, I know v9 alphas are now in progress. A member of @remarkjs/releasers may be able to comment |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemarkParserdoes haveblockTokenizersbut it's missing here.This PR trys to add missing type to
index.d.ts.