Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add types #21

Merged
merged 3 commits into from
Oct 18, 2020
Merged

feat: add types #21

merged 3 commits into from
Oct 18, 2020

Conversation

stefanprobst
Copy link
Contributor

@stefanprobst stefanprobst commented Oct 11, 2020 •
edited
Loading

add types to strip-markdown

closes #20

@codecov-io

This comment has been minimized.

Sign in to view
ChristianMurphy
ChristianMurphy approved these changes Oct 12, 2020
View reviewed changes
types/index.d.ts Outdated Show resolved Hide resolved
ChristianMurphy
ChristianMurphy approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @stefanprobst! 🙇

@stefanprobst
Copy link
Contributor Author

hi, just checking if there is anything missing from my side?

@wooorm
Copy link
Member

wooorm commented Oct 18, 2020

Could you resolve the conflict (should be possible on the GH UI)?
Otherwise look fine, and I’ll get to it soon!

@stefanprobst
Copy link
Contributor Author

done, thanks!

@wooorm wooorm merged commit ba3a801 into remarkjs:main Oct 18, 2020
@wooorm wooorm added ☂️ area/types This affects typings ⛵️ status/released 🦋 type/enhancement This is great to have 🧑 semver/major This is a change labels Oct 18, 2020
@wooorm
Copy link
Member

wooorm commented Oct 18, 2020

Released! thanks!

@stefanprobst stefanprobst deleted the feat/types branch October 18, 2020 15:23
This was referenced May 11, 2021
Closed
Closed
@wooorm wooorm mentioned this pull request Jun 7, 2021
Closed
@wooorm wooorm added the 💪 phase/solved Post is done label Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 🧑 semver/major This is a change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add typescript types
4 participants
@stefanprobst @codecov-io @wooorm @ChristianMurphy