Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish to VS Marketplace #40

Merged
merged 20 commits into from
Mar 21, 2021
Merged

Publish to VS Marketplace #40

merged 20 commits into from
Mar 21, 2021

Commits on Mar 16, 2021

  1. Update package.json metadata 

    Update package.json metadata to reflect the move from @mrmlnc to @remarkjs.
    @asbjornu
    asbjornu committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    0ceb1c6 View commit details
    Browse the repository at this point in the history

  2. Add publish step to the GitHub Actions workflow 

    Modify the GitHub Actions workflow by adding:

- gitversion job
- setup-node step
- version step
- cache step
- publish step
    @asbjornu
    asbjornu committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    c31053d View commit details
    Browse the repository at this point in the history

  3. Add @remarkjs scope

    @asbjornu
    asbjornu committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    b930e90 View commit details
    Browse the repository at this point in the history

  4. Use npm version instead of jq

    @asbjornu
    asbjornu committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    fd8f20e View commit details
    Browse the repository at this point in the history

  5. Set GitVersion to mode ContinuousDeployment

    @asbjornu
    asbjornu committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    cd54bc8 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Separate publish-gpr to its own job

    @asbjornu
    asbjornu committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    1fbdb3f View commit details
    Browse the repository at this point in the history

  2. Ignore .vsix files

    @asbjornu
    asbjornu committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    51642f7 View commit details
    Browse the repository at this point in the history

  3. Add vsce steps 

    - Add vsce steps to publish the extension to the Visual Studio Code Extension Marketplace.
- Remove `vsode:prepublish` since compilation is already done in a previous step.
- Remove the `@remarkjs` scope since VSCE doesn't support it.
- Remove the `publish-gpr` job since the GitHub Package Registry only works with scoped packages: https://docs.github.com/en/packages/guides/configuring-npm-for-use-with-github-packages#publishing-a-package
    @asbjornu
    asbjornu committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    342de9b View commit details
    Browse the repository at this point in the history

  4. Move publish to its own GitHub Actions workflow

    @asbjornu
    asbjornu committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    32183b5 View commit details
    Browse the repository at this point in the history

  5. Bring back publish-gpr

    @asbjornu
    asbjornu committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    00a2f64 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. Suggestions from code review 

    - Use the scoped `registry-url` in this case since the scope is not supplied in the name.
- `scope` is unnecessary as it will be supplied by setup-node-
- Don't trust `npm config`: do it yourself.

Co-authored-by: Joe Bowbeer <joe.bowbeer@gmail.com>
    @asbjornu @joebowbeer
    asbjornu and joebowbeer committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    1f9ebf1 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2021

  1. Remove @remarkjs from the authentication string 

    Co-authored-by: Joe Bowbeer <joe.bowbeer@gmail.com>
    @asbjornu @joebowbeer
    asbjornu and joebowbeer committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    1c64975 View commit details
    Browse the repository at this point in the history

  2. Remove scope from npm registry 

    Co-authored-by: Joe Bowbeer <joe.bowbeer@gmail.com>
    @asbjornu @joebowbeer
    asbjornu and joebowbeer committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    8fb34f1 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2021

  1. Remove publish-gpr as it seems impossible to publish unscoped package… 

    …s to GPR
    @asbjornu
    asbjornu committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    6b13abd View commit details
    Browse the repository at this point in the history

  2. Change publish workflow to only trigger on release publish

    @asbjornu
    asbjornu committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    93f478e View commit details
    Browse the repository at this point in the history

  3. Run vsce package on build as well

    @asbjornu
    asbjornu committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    8b0d865 View commit details
    Browse the repository at this point in the history

  4. Don't run vsce-package on Windows

    @asbjornu
    asbjornu committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    2c0b298 View commit details
    Browse the repository at this point in the history

  5. Move package to its own job and remove gitversion from build

    @asbjornu
    asbjornu committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    a5b6354 View commit details
    Browse the repository at this point in the history

  6. Run npm build on package as well

    @asbjornu
    asbjornu committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    16a9fe2 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2021

  1. Remove whitespace from GitHub Actions expressions

    @asbjornu
    asbjornu committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    70955f9 View commit details
    Browse the repository at this point in the history