Allow arguments on toString() calls

remcohaszing · Aug 22, 2020 · 5c1c26f · 5c1c26f
1 parent ab47bb1
commit 5c1c26f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/eslint-config/core/best-practices.js b/eslint-config/core/best-practices.js
@@ -283,11 +283,7 @@ module.exports = {
   /**
    * https://eslint.org/docs/rules/no-restricted-properties
    */
-  'no-restricted-properties': [
-    'error',
-    { property: 'prototype', message: 'Use a class instead.' },
-    { property: 'toString', message: 'Use String() instread.' },
-  ],
+  'no-restricted-properties': ['error', { property: 'prototype', message: 'Use a class instead.' }],
 
   /**
    * https://eslint.org/docs/rules/no-return-assign

diff --git a/eslint-config/core/stylistic-issues.js b/eslint-config/core/stylistic-issues.js
@@ -368,6 +368,12 @@ module.exports = {
         'TemplateLiteral[expressions.length=1][quasis.0.value.raw=""][quasis.1.value.raw=""]',
       message: 'Use String() instead.',
     },
+    {
+      // `value.toString()`
+      selector: 'CallExpression[callee.property.name="toString"][arguments.length=0]',
+      message: 'Use String() instead.',
+    },
+
     {
       selector: 'SequenceExpression',
       message: 'Split this sequence into multiple statements.',