Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monaco-yaml version 3.2.0 has no validation function #108

Closed
delaprada opened this issue Sep 15, 2021 · 6 comments
Closed

monaco-yaml version 3.2.0 has no validation function #108

delaprada opened this issue Sep 15, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@delaprada
Copy link

delaprada commented Sep 15, 2021

I use version 3.1.0 before and the yaml editor worked well. It had validation and completion function:
image

When I update to version 3.2.0, the validation and completion function doesn't work:
image

@remcohaszing
Copy link
Owner

remcohaszing commented Sep 15, 2021

Thanks for reporting this! I think it might be related to #105

Does your code call setDiagnosticsOptions in a dynamic context? I.e. in a dynamically imported module or inside a Angular/React component, etc.?

Also, do you have a stack trace or reproducible example?

@remcohaszing remcohaszing added the bug Something isn't working label Sep 15, 2021
@delaprada
Copy link
Author

Yes, I use setDiagnosticsOptions inside a React project.

Maybe the example in this issue: #92 can be helpful.

@remcohaszing
Copy link
Owner

Yes, I use setDiagnosticsOptions inside a React project.

Thanks, that’s useful information 😄

Maybe the example in this issue: #92 can be helpful.

It’s different, since in that example setDiagnosticsOptions is called outside of the component.


I intend to fix this soon, when I have time. Until then, I suggest using 3.1.0.

@delaprada
Copy link
Author

Sorry, in my project, setDiagnosticsOptions is called outside of the react component too although it is used in a react project.
Thank you very much and look forward to the subsequent updates.

@remcohaszing
Copy link
Owner

Could you try v3.2.1? I think should be fixed.

@delaprada
Copy link
Author

Yes, v3.2.1 works well. Thank you ☺️.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants