Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type(isEmpty): accept undefined for strings #377

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

eranhirsch
Copy link
Collaborator

@eranhirsch eranhirsch commented Aug 31, 2023

Adds support for undefined for strings (but not for arrays and objects).

Closes #369


Make sure that you:

  • Typedoc added for new methods and updated for changed
  • Tests added for new methods and updated for changed

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 31, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4053542:

Sandbox Source
remeda-example-vanilla Configuration

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0138d52) 99.88% compared to head (4053542) 99.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #377   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files         112      112           
  Lines        6845     6858   +13     
  Branches      618      619    +1     
=======================================
+ Hits         6837     6850   +13     
  Misses          8        8           
Files Changed Coverage Δ
src/isEmpty.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eranhirsch eranhirsch changed the title feat(isEmpty): accept undefined for strings type(isEmpty): accept undefined for strings Sep 1, 2023
@TkDodo TkDodo merged commit 9c79944 into master Sep 1, 2023
23 checks passed
@TkDodo TkDodo deleted the eranhirsch/allowUndefinedForIsEmpty branch September 1, 2023 11:55
@TkDodo
Copy link
Collaborator

TkDodo commented Sep 1, 2023

🎉 This PR is included in version 1.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@TkDodo TkDodo added the released label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isEmpty doesn't accept falsy input
2 participants