Merge pull request #80 from ninesunsabiu/main

feat(remesh): serializable support readonly keyword
remesh-js · Jul 7, 2023 · e5e7576 · e5e7576
2 parents 7b26fbf + b6cd8f8
commit e5e7576
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 4 deletions.
diff --git a/packages/remesh/__tests__/extern.test.ts b/packages/remesh/__tests__/extern.test.ts
@@ -4,7 +4,7 @@ import { map, tap } from 'rxjs'
 describe('extern', () => {
   it('define an extern and use it', () => {
     const memoryCache = (() => {
-      const cache = {}
+      const cache: Record<string, any> = {}
       return {
         get(key: string) {
           return cache[key]

diff --git a/packages/remesh/__tests__/modules.test.ts b/packages/remesh/__tests__/modules.test.ts
@@ -780,6 +780,8 @@ describe('modules', () => {
       id: number
       content: string
       completed: boolean
+      readonly tags: readonly string[]
+      window?: readonly [number, number]
     }
 
     const TestHistoryDomain = Remesh.domain({
@@ -883,6 +885,7 @@ describe('modules', () => {
         id: 0,
         content: 'todo-0',
         completed: true,
+        tags: ['DDD'],
       }),
     )
 
@@ -891,6 +894,7 @@ describe('modules', () => {
         id: 0,
         content: 'todo-0',
         completed: true,
+        tags: ['DDD'],
       },
     ])
 
@@ -901,6 +905,7 @@ describe('modules', () => {
           id: 0,
           content: 'todo-0',
           completed: true,
+          tags: ['DDD'],
         },
       ],
     ])
@@ -916,6 +921,7 @@ describe('modules', () => {
         id: 1,
         content: 'todo-1',
         completed: false,
+        tags: ['CQRS'],
       }),
     )
 
@@ -924,11 +930,13 @@ describe('modules', () => {
         id: 0,
         content: 'todo-0',
         completed: true,
+        tags: ['DDD'],
       },
       {
         id: 1,
         content: 'todo-1',
         completed: false,
+        tags: ['CQRS'],
       },
     ])
 
@@ -939,18 +947,21 @@ describe('modules', () => {
           id: 0,
           content: 'todo-0',
           completed: true,
+          tags: ['DDD'],
         },
       ],
       [
         {
           id: 0,
           content: 'todo-0',
           completed: true,
+          tags: ['DDD'],
         },
         {
           id: 1,
           content: 'todo-1',
           completed: false,
+          tags: ['CQRS'],
         },
       ],
     ])
@@ -968,6 +979,7 @@ describe('modules', () => {
         id: 0,
         content: 'todo-0',
         completed: true,
+        tags: ['DDD'],
       },
     ])
 
@@ -978,18 +990,21 @@ describe('modules', () => {
           id: 0,
           content: 'todo-0',
           completed: true,
+          tags: ['DDD'],
         },
       ],
       [
         {
           id: 0,
           content: 'todo-0',
           completed: true,
+          tags: ['DDD'],
         },
         {
           id: 1,
           content: 'todo-1',
           completed: false,
+          tags: ['CQRS'],
         },
       ],
     ])
@@ -1011,18 +1026,21 @@ describe('modules', () => {
           id: 0,
           content: 'todo-0',
           completed: true,
+          tags: ['DDD'],
         },
       ],
       [
         {
           id: 0,
           content: 'todo-0',
           completed: true,
+          tags: ['DDD'],
         },
         {
           id: 1,
           content: 'todo-1',
           completed: false,
+          tags: ['CQRS'],
         },
       ],
     ])
@@ -1044,18 +1062,21 @@ describe('modules', () => {
           id: 0,
           content: 'todo-0',
           completed: true,
+          tags: ['DDD'],
         },
       ],
       [
         {
           id: 0,
           content: 'todo-0',
           completed: true,
+          tags: ['DDD'],
         },
         {
           id: 1,
           content: 'todo-1',
           completed: false,
+          tags: ['CQRS'],
         },
       ],
     ])
@@ -1073,6 +1094,7 @@ describe('modules', () => {
         id: 0,
         content: 'todo-0',
         completed: true,
+        tags: ['DDD'],
       },
     ])
 
@@ -1083,18 +1105,21 @@ describe('modules', () => {
           id: 0,
           content: 'todo-0',
           completed: true,
+          tags: ['DDD'],
         },
       ],
       [
         {
           id: 0,
           content: 'todo-0',
           completed: true,
+          tags: ['DDD'],
         },
         {
           id: 1,
           content: 'todo-1',
           completed: false,
+          tags: ['CQRS'],
         },
       ],
     ])
@@ -1112,11 +1137,13 @@ describe('modules', () => {
         id: 0,
         content: 'todo-0',
         completed: true,
+        tags: ['DDD'],
       },
       {
         id: 1,
         content: 'todo-1',
         completed: false,
+        tags: ['CQRS'],
       },
     ])
 
@@ -1127,18 +1154,21 @@ describe('modules', () => {
           id: 0,
           content: 'todo-0',
           completed: true,
+          tags: ['DDD'],
         },
       ],
       [
         {
           id: 0,
           content: 'todo-0',
           completed: true,
+          tags: ['DDD'],
         },
         {
           id: 1,
           content: 'todo-1',
           completed: false,
+          tags: ['CQRS'],
         },
       ],
     ])
@@ -1160,18 +1190,21 @@ describe('modules', () => {
           id: 0,
           content: 'todo-0',
           completed: true,
+          tags: ['DDD'],
         },
       ],
       [
         {
           id: 0,
           content: 'todo-0',
           completed: true,
+          tags: ['DDD'],
         },
         {
           id: 1,
           content: 'todo-1',
           completed: false,
+          tags: ['CQRS'],
         },
       ],
     ])
@@ -1187,6 +1220,7 @@ describe('modules', () => {
         id: 2,
         content: 'todo-2',
         completed: true,
+        tags: ['DDD', 'CQRS'],
       }),
     )
 
@@ -1195,6 +1229,7 @@ describe('modules', () => {
         id: 2,
         content: 'todo-2',
         completed: true,
+        tags: ['DDD', 'CQRS'],
       },
     ])
 
@@ -1205,6 +1240,7 @@ describe('modules', () => {
           id: 2,
           content: 'todo-2',
           completed: true,
+          tags: ['DDD', 'CQRS'],
         },
       ],
     ])
@@ -1222,6 +1258,7 @@ describe('modules', () => {
         id: 2,
         content: 'todo-2',
         completed: true,
+        tags: ['DDD', 'CQRS'],
       },
     ])
 

diff --git a/packages/remesh/__tests__/store.test.ts b/packages/remesh/__tests__/store.test.ts
@@ -223,7 +223,7 @@ describe('store', () => {
       },
     })
 
-    const cache = {}
+    const cache: Record<string, any> = {}
     const store2 = RemeshStore({
       name: 'store',
       externs: [

diff --git a/packages/remesh/src/remesh.ts b/packages/remesh/src/remesh.ts
@@ -5,11 +5,12 @@ import { DomainConceptName } from './type'
 
 export type SerializablePrimitives = void | undefined | number | string | boolean | null
 
-export type SerializableArray = Serializable[]
+export type ReadonlySerializableArray = readonly Serializable[]
+export type SerializableArray = Serializable[] | ReadonlySerializableArray
 
 export type SerializableObject = { [key: string]: Serializable }
 
-export type Serializable = SerializablePrimitives | SerializableArray | SerializableObject | Serializable[]
+export type Serializable = SerializablePrimitives | SerializableArray | SerializableObject
 
 export type ToType<T> = T extends object | unknown[]
   ? {