Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test cases for fromEvent, fromQuery refCount bug #93

Closed
wants to merge 1 commit into from
Closed

add test cases for fromEvent, fromQuery refCount bug #93

wants to merge 1 commit into from

Conversation

undoZen
Copy link
Contributor

@undoZen undoZen commented Mar 31, 2024

@hourong88
Copy link

hourong88 commented Mar 31, 2024 via email

@undoZen
Copy link
Contributor Author

undoZen commented Mar 31, 2024

会有内存泄漏：unmount component 后触发的 domain 回收检查不会通过，因为 queryMap 还有工作中的 query subject，但是这个 query subject 应该是在 effect 结束后能被自动收回的。就这里卡住了。需要再看一下

@undoZen
Copy link
Contributor Author

undoZen commented Apr 1, 2024

会有内存泄漏：unmount component 后触发的 domain 回收检查不会通过，因为 queryMap 还有工作中的 query subject，但是这个 query subject 应该是在 effect 结束后能被自动收回的。就这里卡住了。需要再看一下

undoZen@c23b382 这里我推上了 demos 里面 query/index.html 这个页面

@undoZen
Copy link
Contributor Author

undoZen commented Apr 1, 2024

看来把我这里的问题解决了，但是跑 packages/remesh 的测试用例发现坏了几个。只能等聚聚来看一下了。

@undoZen undoZen closed this Apr 1, 2024
@undoZen undoZen changed the title Fix from query bug add test cases for fromEvent, fromQuery refCount bug Apr 1, 2024
@undoZen undoZen reopened this Apr 1, 2024
@undoZen undoZen closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@undoZen @hourong88