Skip to content

Commit

Permalink
Prepare for new Faraday behavior with constructors
Browse files Browse the repository at this point in the history
  • Loading branch information
remi committed Oct 29, 2012
1 parent 92a96a7 commit ca548f1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions lib/her.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
require "faraday"
require "active_support"
require "active_support/inflector"
require "active_support/core_ext/hash"

require "her/model"
require "her/api"
Expand Down
2 changes: 1 addition & 1 deletion lib/her/api.rb
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def setup(attrs={}) # {{{
attrs[:url] = attrs.delete(:base_uri) if attrs.include?(:base_uri) # Support legacy :base_uri option
@base_uri = attrs[:url]
@options = attrs
@connection = Faraday.new(attrs) do |connection|
@connection = Faraday.new(attrs.slice(:url)) do |connection|
yield connection if block_given?
end
end # }}}
Expand Down

4 comments on commit ca548f1

@pencil
Copy link
Collaborator

@pencil pencil commented on ca548f1 Nov 2, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SSL does no longer work as documented. 😱

@remi
Copy link
Owner Author

@remi remi commented on ca548f1 Nov 2, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh shoot, you’re right. Fixed in 4b0b0d4.

@calmyournerves
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@pencil
Copy link
Collaborator

@pencil pencil commented on ca548f1 Nov 2, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😄

Please sign in to comment.