Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activesupport >= 4.3.0 #392

Closed
rafaelgonzalez opened this issue Jan 6, 2016 · 9 comments
Closed

Activesupport >= 4.3.0 #392

rafaelgonzalez opened this issue Jan 6, 2016 · 9 comments

Comments

@rafaelgonzalez
Copy link

Hello & happy new year!

Rails v5.0.0.beta1 was released a couple of weeks ago, and we are planning on upgrading one of our apps that uses Her to Rails 5.

Rails 5 requires activesupport v5.0.0.beta1 and Her currently supports it up to 4.2.0.

Now, I see there are specific Gemfiles for each version of activemodel, so I can make a PR with her/gemfiles/Gemfile.activemodel-5.0.0.beta1 if you are down for supporting a beta version, or maybe her/gemfiles/Gemfile.activemodel-5.0.x ?

Let me know your thoughts.

Cheers

@djpate
Copy link

djpate commented Jan 29, 2016

+1

1 similar comment
@oliverzeyen
Copy link

👍

@bronson
Copy link

bronson commented Feb 24, 2016

Yup, it's time!

@mokus80
Copy link

mokus80 commented Apr 21, 2016

+1

@tokhi
Copy link

tokhi commented Apr 21, 2016

Even beta3 is out now.

@leighmackay-catapult
Copy link

+1

@rafaelgonzalez
Copy link
Author

Let's all support #399 !

@johan-smits
Copy link

+1

@edtjones
Copy link
Collaborator

Hi folks,

I've just taken over maintenance of this gem and pushed 0.8.2 which includes support for Rails 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants