supporting activemodel >= 5.0 #392 #399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge this in. Gems that depend on Her and that are included in a Rails app are blocking upgrading to Rails 5. |
Closed
| @@ -23,8 +23,8 @@ Gem::Specification.new do |s| | |||
| s.add_development_dependency "fivemat", "~> 1.2" | |||
| s.add_development_dependency "json", "~> 1.8" | |||
|
|
|||
| s.add_runtime_dependency "activemodel", ">= 3.0.0", "<= 4.3.0" | |||
| s.add_runtime_dependency "activesupport", ">= 3.0.0", "<= 4.3.0" | |||
| s.add_runtime_dependency "activemodel", ">= 3.0.0", "<= 5.0.0" | |||
There was a problem hiding this comment.
Shouldn't this be < 5.1.0 so patches to rails 5 are compatible?
|
If anyone really wants to use this, I've forked and created a new gem: https://rubygems.org/gems/her5 |
|
+1 |
1 similar comment
|
+1 |
|
hi @zkwentz @ryanswood @arturseletskiy @jkappers I've just got commit access to this repo and this will be my first merge! Will keep you posted here. |
|
Hi folks, Rather than accept this PR I've written a slightly more permissive change to the gemspec. I'll close this one now. Ed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.