test breakage under Faraday 0.9.x/1.0 (pre-release)

[technoweenie]

Hey, I've made some radical changes to the underlying builder/middleware system in Faraday. Her has just one test failure when run in legacy mode:

  1) Her::API initialization#setup takes custom options
     Failure/Error: @api.setup :foo => { :bar => "baz" }, :url => "https://api.example.com"
     NoMethodError:
       undefined method `foo=' for #<Faraday::ConnectionOptions:0x007ffabf31c538>
     # ./lib/her/api.rb:56:in `setup'
     # ./spec/api_spec.rb:34:in `block (4 levels) in <top (required)>'

Faraday 0.9 and up has replaced the nested hashes that Faraday::Connection.new takes in favor of Structs. The benefit is that misspelled options immediately raise exceptions, instead of subtly introducing bugs. The downside is that you can no longer pass custom options around.

Is Her relying on this functionality?

[remi]

No, Her is not relying on this functionality. Parameters are just stored in Her::API and I was passing them to Faraday.new because it contains the url required parameter.

I just pushed ca548f1 to make sure Her will run fine in future Faraday versions (at least in legacy mode for now). I’ll look into the new callbacks/middleware structure later.

Thanks for the notice!