You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Faraday 0.9 and up has replaced the nested hashes that Faraday::Connection.new takes in favor of Structs. The benefit is that misspelled options immediately raise exceptions, instead of subtly introducing bugs. The downside is that you can no longer pass custom options around.
Is Her relying on this functionality?
The text was updated successfully, but these errors were encountered:
No, Her is not relying on this functionality. Parameters are just stored in Her::API and I was passing them to Faraday.new because it contains the url required parameter.
I just pushed ca548f1 to make sure Her will run fine in future Faraday versions (at least in legacy mode for now). I’ll look into the new callbacks/middleware structure later.
Hey, I've made some radical changes to the underlying builder/middleware system in Faraday. Her has just one test failure when run in legacy mode:
Faraday 0.9 and up has replaced the nested hashes that
Faraday::Connection.new
takes in favor of Structs. The benefit is that misspelled options immediately raise exceptions, instead of subtly introducing bugs. The downside is that you can no longer pass custom options around.Is Her relying on this functionality?
The text was updated successfully, but these errors were encountered: