Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Faraday 1.0.X #537

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Support Faraday 1.0.X #537

merged 1 commit into from
Mar 25, 2021

Conversation

bvicenzo
Copy link
Contributor

In this issue is discussed support to Faraday 1.0, Ruby 2.7, and Rails 6...

This PR intent to do one part of this, giving to users the possibility of using Faraday 1.0.X with Her gem...

@bvicenzo bvicenzo force-pushed the bv-support-faraday-1.0 branch 3 times, most recently from 2fec02f to 5c7471c Compare July 29, 2020 15:25
@prashanth-balaboina
Copy link

prashanth-balaboina commented Sep 29, 2020

Any ETA on getting this worked on ? Would really like this update.

cc: @zacharywelch and @edtjones

@bvicenzo
Copy link
Contributor Author

bvicenzo commented Mar 8, 2021

@zacharywelch @edtjones @remi Could you help us here?

@patricia-tonella
Copy link

patricia-tonella commented Mar 24, 2021

Any ETA on getting this worked on ? Would really like this update.

cc: @zacharywelch and @edtjones

It would be a great assistance for my team (and for many other teams) if you guys could post any update on this topic. 👀
We are waiting for this update to update other gems in our project.

cc. @zacharywelch @edtjones @remi

@edtjones
Copy link
Collaborator

Hi @ptonella @bvicenzo thanks for chasing this. @zacharywelch and I are both snowed under with other stuff and haven't had time to maintain this gem at the moment; if you would like to continue this task we can ask @remi to add you as a committer.

@bvicenzo
Copy link
Contributor Author

Just FIY, I've been using this gem fix in production since Jul 2020 this way:

gem 'her', git: 'https://github.com/bvicenzo/her.git', branch: 'bv-support-faraday-1.0'

And updated other dependencies to Faraday 1.X...

It's working as expected...

it may be considered a good test...

@remi
Copy link
Owner

remi commented Mar 25, 2021

Sorry everyone, I haven’t had the time to check on issues related to this project.

@bvicenzo Would you like to help with this project as a maintainer?

@remi remi merged commit 9ddf62c into remi:master Mar 25, 2021
@bvicenzo bvicenzo deleted the bv-support-faraday-1.0 branch March 25, 2021 16:31
@bvicenzo
Copy link
Contributor Author

Man, thanks for the invite.
However, I'm not working at the company where I've used this gem...
so, I believe that I'll not have the context to help as a maintainer... :(

@thiagodiniz
Copy link
Contributor

thiagodiniz commented Apr 13, 2021

@remi could you change the version to 1.1.1 in order to update the ruby gems: https://rubygems.org/gems/her.

Because the version wasn't changed, the rubygem still have the previous version.

To fasten things up I opened a PR: #541

@kivanio
Copy link

kivanio commented Apr 16, 2021

@remi @thiagodiniz and I can help you with maintainer 👍

@remi
Copy link
Owner

remi commented Apr 16, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants