Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop when parsing nested associations #539

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gordysc
Copy link

@gordysc gordysc commented Sep 10, 2020

It appears with this commit a potential infinite loop was introduced if models defined both has_many/belongs_to.

To mitigate this, I've added a straightforward check for belongs_to to no-op if the association is already defined on the resulting object. Also, sorry for the previous PR! Moved this under my company's organization for easy access to the rest of my team.

Finally, it appears we're now respecting included_root_element for nested associations. This PR also adds an option to opt out of this new behavior as well as potentially use a different name via included_embedded_root_element

@gabrielrdrguez
Copy link

gabrielrdrguez commented Sep 15, 2021

Somebody please give a medal to this man! (and merge this PR 😛 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants