has_many_association: Deal with empty 204 status code #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you register a relationship as a `has_many` and you this resource endpoint return a 204 we should handle this gracefully, by returning a empty array. This patch leverages the default return type defined on the relationship (`@opts[:default]`) to construct which sort of response it would expect (`get_collection` or a regular `get`). The default parser, is dumb and therefore cannot distinguish if when it receives a 204 it should transform that into a hash or an array, and always convert the response into a empty hash. So, on the attributes.rb method called `instantiate_collection` when we stumble upon a empty hash we always convert into an empty array.
|
Hello, just a quick ping on this PR for review @remi @zacharywelch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you register a relationship as a
has_manyand you this resourceendpoint return a 204 we should handle this gracefully, by returning a
empty array. This patch leverages the default return type defined on the
relationship (
@opts[:default]) to construct which sort of response itwould expect (
get_collectionor a regularget).The default parser, is dumb and therefore cannot distinguish if when it
receives a 204 it should transform that into a hash or an array, and
always convert the response into a empty hash. So, on the
attributes.rb method called
instantiate_collectionwhen we stumbleupon a empty hash we always convert into an empty array.