Rhel6+langpacks #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to what we do for firefox already.
|
Even if I don't plan to build EL packages for FF/TH, I could merge this changes (for version 8) , except than, for now, it isn't correct %if 0%{?fedora} < 14 || 0%{?rhel} <= 6 This test is always true. Must be : %if 0%{?fedora} < 14 && 0%{?rhel} <= 6 |
Of course the way these tests are written, they always evaluate to true.
|
Ah, of course you are right. A bit embarrassing, really. I can see the commit just made it above. We don't have any Fedoras so I cannot really regression test this unfortunately. |
remicollet
added a commit
that referenced
this pull request
Dec 1, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At my office we are using the spec files for Thunderbird and Firefox from your repo as they seem to be cleanest and most maintained by the lot. We had to make a couple of changes that I hope can make their way to your repo.