Order by version and desc, even when the Range

header is not present.
remind101 · Jul 24, 2015 · abf75f6 · abf75f6
1 parent 8bb02ba
commit abf75f6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/releases.go b/releases.go
@@ -74,6 +74,8 @@ func (q ReleasesQuery) Scope(db *gorm.DB) *gorm.DB {
 
 	if r := q.Range; r != nil {
 		scope = append(scope, Range(r))
+	} else {
+		scope = append(scope, Order("version desc"))
 	}
 
 	// Preload all the things.

diff --git a/releases_test.go b/releases_test.go
@@ -22,7 +22,7 @@ func TestReleasesQuery(t *testing.T) {
 	}
 
 	tests := scopeTests{
-		{ReleasesQuery{}, "", []interface{}{}},
+		{ReleasesQuery{}, "ORDER BY version desc", []interface{}{}},
 		{ReleasesQuery{Range: rangeHeader}, "ORDER BY version desc LIMIT 20", []interface{}{}},
 		{ReleasesQuery{App: app, Range: rangeHeader}, "WHERE (app_id = $1) ORDER BY version desc LIMIT 20", []interface{}{"1234"}},
 		{ReleasesQuery{Version: &version, Range: rangeHeader}, "WHERE (version = $1) ORDER BY version desc LIMIT 20", []interface{}{1}},